-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: client telemetry #121
Conversation
I hacked the endpoint to prod, and saw the attached json show up under ds-hub-telemetry. NB that I will need to apply https://github.com/huggingface-internal/infra/pull/1631 to see the records as parsed timestamps and counts instead of strings
and logs sent to telemetry endpoint at https://huggingface.co/api/telemetry/xet/cli attached below |
ee582ba
to
a4efa48
Compare
@port8080 After some discussions with @ylow @XciD @julien-c , we would prefer to be extra careful when implementing client-side telemetry. We advocate for keeping server-side metrics. I understand that client-side may be useful for local cache hits assessment, if you really want to keep it let's make it opt-in for testing people but not the default 😄 |
a4efa48
to
54b0dea
Compare
Moving fwd with this after #142 and a discussion between @rajatarya and @XciD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this implode if we update the JWT contents?
@ylow JWT parsing failure will cause repo_id to be |
I ran it e2e with the hash based approach and it works.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me!
No description provided.