Before update the tr_loss, make sure tr_loss_step is in the same device. #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Co-authored-by: guy1992l <[email protected]>
younesbelkada
approved these changes
Mar 19, 2024
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
just double checking @kashif is this all good in your opinion? |
kashif
approved these changes
Mar 19, 2024
lapp0
pushed a commit
to lapp0/trl
that referenced
this pull request
May 10, 2024
…ce. (huggingface#1439) * before update the loss from dpo, make sure it's in the same device of tr_loss * Update trl/trainer/dpo_trainer.py Co-authored-by: guy1992l <[email protected]> --------- Co-authored-by: guy1992l <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes: #958
Fixes: #1399
It's a very strong assumption that
tr_lossandtr_loss_stepare on the same device.arg.devicemay not be as same as the current device.For example, the
dpo_traineris child class oftrainer. If you are running a DPO training job with one node multiple GPUs. If you set thedevice_map='auto'. Thetr_loss_stepcould be on different device after computing thedpo_loss.Based on the feedback of @guy1992l, @younesbelkada, @amyeroberts, I have open a PR in the transformers
Trainerclass to do a assert checking.huggingface/transformers#29695
This PR is put the
tr_loss_stepto theself.args.devicebefore update.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@younesbelkada
@amyeroberts
@guy1992l
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.