Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paligemma warning message #35486

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Conversation

hiyouga
Copy link
Contributor

@hiyouga hiyouga commented Jan 2, 2025

What does this PR do?

Fixes hiyouga/LLaMA-Factory#6499

The logger.warning_once method only accepts one argument, so we remove the comma.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@zucchini-nlp

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for the PR and fix @hiyouga!

@LysandreJik LysandreJik merged commit 4286586 into huggingface:main Jan 2, 2025
14 checks passed
AlanPonnachan pushed a commit to AlanPonnachan/transformers that referenced this pull request Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

paligemma2-3b-pt-448在进行eval&predict时出现Logging error导致无法继续测试
2 participants