Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize HF_ACCESS_TOKEN -> HF_TOKEN #431

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Standardize HF_ACCESS_TOKEN -> HF_TOKEN #431

merged 1 commit into from
Dec 6, 2023

Conversation

xenova
Copy link
Collaborator

@xenova xenova commented Dec 5, 2023

This PR standardizes the name of the environment variable used to make requests with a HF API token.

cc @Wauplin

Copy link
Member

@julien-c julien-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Copy link

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating @xenova ❤️

coyotte508 added a commit to huggingface/huggingface.js that referenced this pull request Dec 5, 2023
Same as huggingface/transformers.js#431.
Related to [slack
thread](https://huggingface.slack.com/archives/C021H1P1HKR/p1701775450614369?thread_ts=1701719404.424999&cid=C021H1P1HKR)
(internal).

This PR standardizes the name of the environment variable used to make
requests with a HF API token. The goal is to harmonize it across the HF
ecosystem. For what I've seen, `HF_ACCESS_TOKEN` was not an "official"
environment variable but simply the one used in docs and tests. Updating
the naming should not break anything in the libraries.

**TODO before merging** update `HF_ACCESS_TOKEN` to `HF_TOKEN` in Github
repo secrets.

cc @xenova @julien-c

Co-authored-by: Eliott C <[email protected]>
@xenova xenova merged commit 374c105 into main Dec 6, 2023
4 checks passed
@xenova xenova deleted the update-env-vars branch December 6, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants