Add PDFParser #187
Open
Add PDFParser #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Partially fixes #176 |
|
@merveenoyan thank you for this addition! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds PDFParsingTool with GOT-OCR 2.0.
Note that this model isn't yet integrated with transformers (there's a PR for it), I don't know when it will be merged hence loading with
trust_remote_codeand not usingPipelineTool. (they implemented custom methods to do forward that abstracts away a bunch of things, I used it)How should we take file inputs? Now we only take path.
An issue with this model is that it comes with two extra dependencies: tiktoken and verovio.
We could add extra dependencies for this tool like
pip install smolagents["pdf"].WDYT? @aymeric-roucher