Skip to content

Commit

Permalink
raise not implemented error for conv1d dora
Browse files Browse the repository at this point in the history
  • Loading branch information
CCLDArjun committed Jan 22, 2025
1 parent bae612f commit ba03b7a
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/peft/tuners/lora/layer.py
Original file line number Diff line number Diff line change
Expand Up @@ -1306,6 +1306,9 @@ def __init__(self, *args, **kwargs):
raise ValueError(f"Conv1d layer kernel must have 3 dimensions, not {self._kernel_dim}")
self.conv_fn = F.conv1d

def _get_dora_layer_class(self):
raise NotImplementedError

class Conv3d(_ConvNd):
# Lora implemented in a conv3d layer
def __init__(self, *args, **kwargs):
Expand Down

0 comments on commit ba03b7a

Please sign in to comment.