-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PRC models to test_text_generation_example.py #1695
base: main
Are you sure you want to change the base?
Add PRC models to test_text_generation_example.py #1695
Conversation
Signed-off-by: Chen, Wenbin <[email protected]>
@wenbinc-Bin would you please post the test results with these additions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hi @regisss, this PR is ready for your final review. Could you please take a look?
>>> RUN_SLOW=true GAUDI2_CI=1 python -m pytest tests/test_text_generation_example.py -s -v -k qwen --token $(TOKEN)
12 passed, 64 deselected, 1 warning in 640.85s (0:10:40) |
Also chaglm2
|
@wenbinc-Bin do we need to add all the tests? Maybe we can remove |
Signed-off-by: Chen, Wenbin <[email protected]>
I can remove them. 14B models are relatively less important. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @regisss, this PR is ready for your final review. Could you please take a look?
What does this PR do?
Add Chinese models to test_text_generation_example.py