-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fea(): reworked the 8x hpu skipping strategy #1694
Conversation
@dsocek take a look when you had a chance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, as we discussed this should fix the observed issue with custom ops test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hi @regisss, this PR is ready for your final review. Could you please take a look?
@imangohari1 LGTM! There is a merge conflict to solve. |
209dc9f
to
4898108
Compare
@regisss Thanks for the review! I resolved the conflicts. |
The code quality check failed, please run |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
What does this PR do?
a Follow up on #1655, re-structured the check of 8x-HPU avail on system without loading the
import habana_frameworks.torch.hpu as hthpu
Fixes # (issue)
Before submitting