Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fea(): reworked the 8x hpu skipping strategy #1694

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

imangohari1
Copy link
Contributor

What does this PR do?

a Follow up on #1655, re-structured the check of 8x-HPU avail on system without loading the import habana_frameworks.torch.hpu as hthpu

GAUDI2_CI=1 RUN_SLOW=true python -m pytest tests/test_diffusers.py -s -v -k textual_inversion
========================================================= test session starts =========================================================
platform linux -- Python 3.10.12, pytest-7.4.4, pluggy-1.5.0 -- /usr/bin/python3
cachedir: .pytest_cache
rootdir: /devops/sgohari/tests/codes/ig/optimum-habana
configfile: setup.cfg
collected 165 items / 163 deselected / 2 selected

7.jpeg: 100%|███████████████████████████████████████████████████████████████████████████████████████| 160k/160k [00:00<00:00, 57.2MB/s]
4.jpeg: 100%|███████████████████████████████████████████████████████████████████████████████████████| 150k/150k [00:00<00:00, 54.7MB/s]
6.jpeg: 100%|███████████████████████████████████████████████████████████████████████████████████████| 435k/435k [00:00<00:00, 92.4MB/s]
1.jpeg: 100%|

.
.
======================================================= short test summary info =======================================================
FAILED tests/test_diffusers.py::GaudiStableDiffusionXLPipelineTester::test_textual_inversion_sdxl - AssertionError: 2.384394115335883 not greater than or equal to 2.53593
================================= 1 failed, 1 passed, 163 deselected, 3 warnings in 403.37s (0:06:43) =======

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@imangohari1 imangohari1 requested a review from regisss as a code owner January 10, 2025 18:57
@imangohari1
Copy link
Contributor Author

@dsocek take a look when you had a chance.

Copy link
Contributor

@dsocek dsocek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, as we discussed this should fix the observed issue with custom ops test

@emascarenhas
Copy link
Contributor

@dsocek @yafshar , Can you update the status, is this ready for merge?

Copy link
Contributor

@yafshar yafshar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Hi @regisss, this PR is ready for your final review. Could you please take a look?

@regisss
Copy link
Collaborator

regisss commented Jan 30, 2025

@imangohari1 LGTM! There is a merge conflict to solve.

@imangohari1 imangohari1 force-pushed the ig/test_diff_hthpu-fix branch from 209dc9f to 4898108 Compare January 30, 2025 15:53
@imangohari1
Copy link
Contributor Author

@imangohari1 LGTM! There is a merge conflict to solve.

@regisss Thanks for the review! I resolved the conflicts.

Copy link

The code quality check failed, please run make style.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@imangohari1
Copy link
Contributor Author

make style is done.

The code quality check failed, please run make style.

@regisss regisss merged commit 4a3a9a8 into huggingface:main Jan 30, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants