Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[InferenceClient] Renaming extra_parameters to extra_body #2821

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

hanouticelina
Copy link
Contributor

Originally suggested by @julien-c here. This way we maintain consistency with OpenAI's python sdk. I took the opportunity to add this argument to chat_completion as well.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.42%. Comparing base (503d353) to head (c80974c).
Report is 60 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2821       +/-   ##
===========================================
+ Coverage   49.47%   82.42%   +32.94%     
===========================================
  Files         106      114        +8     
  Lines       11165    11807      +642     
===========================================
+ Hits         5524     9732     +4208     
+ Misses       5641     2075     -3566     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hanouticelina hanouticelina merged commit d959b4f into main Feb 3, 2025
17 checks passed
@hanouticelina hanouticelina deleted the rename-extra-parameters branch February 3, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants