Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deps] Increment Sentence Transformers to v3.3.1 #464

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

tomaarsen
Copy link
Member

@tomaarsen tomaarsen commented Jan 17, 2025

Hello!

Pull Request overview

  • Increment Sentence Transformers to v3.3.1

Details

I tested this locally with static-similarity-mrl-multilingual-v1, and it worked. Before this PR, this error is given:
image

Sentence Transformers and Transformers, are backwards compatible, so this shouldn't cause any issues.
cc @Narsil

  • Tom Aarsen

@tomaarsen tomaarsen requested a review from Narsil January 17, 2025 13:41
@tomaarsen
Copy link
Member Author

Tests are failing due to the Python 3.8 used; which is now deprecated in Sentence Transformers, Transformers, HuggingFace Hub, etc.
An easy fix is to bump the Python version in the test runner, but I'm not sure what's actually being ran on the HF side, we can't have that be 3.8 anymore.

  • Tom Aarsen

@Narsil Narsil merged commit 62f64c2 into huggingface:main Jan 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants