-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👷 Automatically dispatch tasks to hf.js #355
base: main
Are you sure you want to change the base?
Conversation
Thanks for the ping @coyotte508. We don't have a |
This dispatch thing looks really cool! I haven't used this feature but the code seems reasonable. |
client-payload: | | ||
{ | ||
"tasks": ${{ steps.export_tasks.outputs.payload }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! How is this payload received and interpreted in the remote repo, is that already in place?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now that the PR is approved as soon as #355 (comment) is handled will work on it
we need to create a github workflow with repository_dispatch on hf.js
@glegendre01 now that the PR is approved can you handle that please 🙏 ?
(don't have admin access on the repo and we probably want a token from machineuser) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@osanseviero are we sure this is needed?
I feel like with the Inference revamp will we even still have this repo?
@coyotte508, secret created. can you test it ? |
@julien-c fair point; let's pause this PR as a bunch of this might be unneeded in a couple of weeks and this is mostly to update a |
ok for the record @glegendre01 the token works (reran job with ✔️) |
ok, keep me informed if we need to clean up the token finally |
This will send a dispatch even to hf.js, where we need to create a matching action to receive the event with
repository_dispatch
: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#repository_dispatchThis will allow us to automate updating https://github.com/huggingface/huggingface.js/blob/main/packages/tasks/src/library-to-tasks.ts (with an action that will open a PR to this file)
cc @pcuenca @mishig25 @osanseviero @julien-c
cc @Wauplin in case you might want that too for some reason
Migration
Set a
REPO_DISPATCH_TOKEN
secret, a PAT that has read/write & metadata onhuggingface/huggingface.js