Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(fgs/async): using auto-gen style to replace old coding #6328

Conversation

Lance52259
Copy link
Contributor

@Lance52259 Lance52259 commented Feb 14, 2025

What this PR does / why we need it:
New acceptance to coverage the destination configuration structure when it is empty.
Refactor the async configuration resource and using auto-generate style to replace the old coding.
image

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

1. new acceptance to coverage the destination configuration structure when it is empty.
2. using auto-gen style to replace old coding.

PR Checklist

  • [x Tests added/passed.
./scripts/coverage.sh -o fgs -f TestAccAsyncInvokeConfig
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/fgs" -v -coverprofile="./huaweicloud/services/acceptance/fgs/fgs_coverage.cov" -coverpkg="./huaweicloud/services/fgs" -run TestAccAsyncInvokeConfig -timeout 360m -parallel 10
=== RUN   TestAccAsyncInvokeConfig_basic
=== PAUSE TestAccAsyncInvokeConfig_basic
=== RUN   TestAccAsyncInvokeConfig_withoutDestConfigs
=== PAUSE TestAccAsyncInvokeConfig_withoutDestConfigs
=== CONT  TestAccAsyncInvokeConfig_basic
=== CONT  TestAccAsyncInvokeConfig_withoutDestConfigs
--- PASS: TestAccAsyncInvokeConfig_withoutDestConfigs (21.66s)
--- PASS: TestAccAsyncInvokeConfig_basic (28.94s)
PASS
coverage: 14.6% of statements in ./huaweicloud/services/fgs
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/fgs       29.003s coverage: 14.6% of statements in ./huaweicloud/services/fgs
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@deer-hang
Copy link
Contributor

/approve
/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Feb 14, 2025
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @deer-hang

/approve
/lgtm

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2025
@github-ci-robot github-ci-robot merged commit 706234c into huaweicloud:master Feb 14, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. LGTM /lgtm refactor size/L test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants