Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CodeArts/Deploy): fix error and add acc test #6292

Conversation

saf3dfsa
Copy link
Contributor

What this PR does / why we need it:
fix error and add acc test
Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
./scripts/acc-test.sh 

run acceptance tests of huaweicloud/services/acceptance/codeartsdeploy/resource_huaweicloud_codearts_deploy_application_test.go:
=== RUN   TestAccDeployApplication_basic
=== PAUSE TestAccDeployApplication_basic
=== RUN   TestAccDeployApplication_resourcePoolId
=== PAUSE TestAccDeployApplication_resourcePoolId
=== RUN   TestAccDeployApplication_errorCheckInvalidArgument
=== PAUSE TestAccDeployApplication_errorCheckInvalidArgument
=== RUN   TestAccDeployApplication_conflict
=== PAUSE TestAccDeployApplication_conflict
=== CONT  TestAccDeployApplication_basic
=== CONT  TestAccDeployApplication_errorCheckInvalidArgument
=== CONT  TestAccDeployApplication_resourcePoolId
=== CONT  TestAccDeployApplication_conflict
=== CONT  TestAccDeployApplication_resourcePoolId
    acceptance.go:1924: HW_CODEARTS_RESOURCE_POOL_ID must be set for this acceptance test
--- SKIP: TestAccDeployApplication_resourcePoolId (0.00s)
--- PASS: TestAccDeployApplication_errorCheckInvalidArgument (3.27s)
--- PASS: TestAccDeployApplication_conflict (55.57s)
--- PASS: TestAccDeployApplication_basic (56.18s)
PASS
coverage: 20.8% of statements in ./huaweicloud/services/codeartsdeploy
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/codeartsdeploy    56.238s coverage: 20.8% of statements in ./huaweicloud/services/codeartsdeploy

run acceptance tests of huaweicloud/services/acceptance/codeartsdeploy/resource_huaweicloud_codearts_deploy_application_permission_test.go:
=== RUN   TestAccDeployApplicationPermissionModify_basic
=== PAUSE TestAccDeployApplicationPermissionModify_basic
=== RUN   TestAccDeployApplicationPermissionModify_conflict
=== PAUSE TestAccDeployApplicationPermissionModify_conflict
=== CONT  TestAccDeployApplicationPermissionModify_basic
=== CONT  TestAccDeployApplicationPermissionModify_conflict
--- PASS: TestAccDeployApplicationPermissionModify_conflict (52.14s)
--- PASS: TestAccDeployApplicationPermissionModify_basic (67.35s)
PASS
coverage: 15.2% of statements in ./huaweicloud/services/codeartsdeploy
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/codeartsdeploy    67.420s coverage: 15.2% of statements in ./huaweicloud/services/codeartsdeploy

run acceptance tests of huaweicloud/services/acceptance/codeartsdeploy/resource_huaweicloud_codearts_deploy_group_test.go:
=== RUN   TestAccDeployGroup_basic
=== PAUSE TestAccDeployGroup_basic
=== RUN   TestAccDeployGroup_resourcePoolId
=== PAUSE TestAccDeployGroup_resourcePoolId
=== CONT  TestAccDeployGroup_basic
=== CONT  TestAccDeployGroup_resourcePoolId
    acceptance.go:1924: HW_CODEARTS_RESOURCE_POOL_ID must be set for this acceptance test
--- SKIP: TestAccDeployGroup_resourcePoolId (0.00s)
--- PASS: TestAccDeployGroup_basic (37.90s)
PASS
coverage: 9.5% of statements in ./huaweicloud/services/codeartsdeploy
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/codeartsdeploy    37.953s coverage: 9.5% of statements in ./huaweicloud/services/codeartsdeploy

### coverage of files in huaweicloud/services:

- github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/codeartsdeploy/resource_huaweicloud_codearts_deploy_application.go (80.6%)
- github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/codeartsdeploy/resource_huaweicloud_codearts_deploy_application_permission.go (86.4%)
- github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/codeartsdeploy/resource_huaweicloud_codearts_deploy_group.go (80.6%)

### [summary] 0 failed in 3 resource acceptance tests
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@houpeng80
Copy link
Collaborator

/lgtm
/approve

@github-ci-robot github-ci-robot added the LGTM /lgtm label Feb 12, 2025
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @houpeng80

/lgtm
/approve

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2025
@github-ci-robot github-ci-robot merged commit f0747b4 into huaweicloud:master Feb 12, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugfix LGTM /lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants