Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(fgs/dependency): using auto-gen style to replace old coding #6289

Conversation

Lance52259
Copy link
Contributor

What this PR does / why we need it:
Using auto-gen style to replace old coding for the FunctionGraph dependency versions data source.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

1. using auto-gen style to replace old coding for the FunctionGraph dependency versions data source.

PR Checklist

  • Tests added/passed.
make testacc TEST='./huaweicloud' TESTARGS='-run=TestAccSomethingV0_basic'
...
=== RUN   TestAccSomethingV0_basic
--- PASS: TestAccSomethingV0_basic (70.75s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud       70.796s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@Lance52259 Lance52259 force-pushed the br_fgs_data_dependency_versions_refactor branch from 33e13cb to d9e912b Compare February 14, 2025 01:53
@github-actions github-actions bot added the test label Feb 14, 2025
@Lance52259 Lance52259 changed the title [WIP]refactor(fgs/dependency): using auto-gen style to replace old coding refactor(fgs/dependency): using auto-gen style to replace old coding Feb 14, 2025
@deer-hang
Copy link
Contributor

/approve
/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Feb 14, 2025
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @deer-hang

/approve
/lgtm

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2025
@github-ci-robot github-ci-robot merged commit 01e62b5 into huaweicloud:master Feb 14, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. LGTM /lgtm refactor size/M test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants