Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(iotda): refactor iotda space resource code style #6274

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

ruwenqiang123
Copy link
Contributor

What this PR does / why we need it:

refactor iotda space resource code style.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
$ make testacc TEST="./huaweicloud/services/acceptance/iotda" TESTARGS="-run TestAccSpace_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/iotda -v -run TestAccSpace_basic -timeout 360m -parallel 4
=== RUN   TestAccSpace_basic
--- PASS: TestAccSpace_basic (39.20s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/iotda     39.250s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<
      image
    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<
      image

@jinyangyang222
Copy link
Contributor

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Feb 8, 2025
@deer-hang
Copy link
Contributor

/approve

Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @deer-hang

/approve

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2025
@github-ci-robot github-ci-robot merged commit 04b00b5 into huaweicloud:master Feb 10, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. LGTM /lgtm refactor size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants