Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(hss): refactor web tamper protection resource code style #6250

Conversation

jinyangyang222
Copy link
Contributor

@jinyangyang222 jinyangyang222 commented Jan 23, 2025

What this PR does / why we need it:

refactor web tamper protection resource code style

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


refactor web tamper protection resource code style

PR Checklist

  • Tests added/passed.
$ export HW_HSS_HOST_PROTECTION_HOST_ID=xxxxxxxxxxxxx

$ make testacc TEST="./huaweicloud/services/acceptance/hss" TESTARGS="-run TestAccWebTamperProtection_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/hss -v -run TestAccWebTamperProtection_basic -timeout 360m -parallel 4
=== RUN   TestAccWebTamperProtection_basic
=== PAUSE TestAccWebTamperProtection_basic
=== CONT  TestAccWebTamperProtection_basic
--- PASS: TestAccWebTamperProtection_basic (94.01s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/hss       94.074s

$ make testacc TEST="./huaweicloud/services/acceptance/hss" TESTARGS="-run TestAccWebTamperProtection_noFillQuotaId"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/hss -v -run TestAccWebTamperProtection_noFillQuotaId -timeout 360m -parallel 4
=== RUN   TestAccWebTamperProtection_noFillQuotaId
=== PAUSE TestAccWebTamperProtection_noFillQuotaId
=== CONT  TestAccWebTamperProtection_noFillQuotaId
--- PASS: TestAccWebTamperProtection_noFillQuotaId (85.70s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/hss       85.746s

image

  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      image

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@jinyangyang222 jinyangyang222 force-pushed the refactor-hss/refactor-webtamper_protection-codeStyle branch from 7cea00f to ff372d0 Compare January 23, 2025 08:01
@jinyangyang222 jinyangyang222 changed the title refactor(hss): refactor webtamper protection code style refactor(hss): refactor webtamper protection resource code style Jan 23, 2025
@jinyangyang222 jinyangyang222 changed the title refactor(hss): refactor webtamper protection resource code style refactor(hss): refactor web tamper protection resource code style Jan 23, 2025
@jinyangyang222 jinyangyang222 force-pushed the refactor-hss/refactor-webtamper_protection-codeStyle branch from ff372d0 to bc8ffb9 Compare February 8, 2025 02:59
@jinyangyang222 jinyangyang222 force-pushed the refactor-hss/refactor-webtamper_protection-codeStyle branch from bc8ffb9 to a82b647 Compare February 8, 2025 03:09
@deer-hang
Copy link
Contributor

/approve
/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Feb 10, 2025
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @deer-hang

/approve
/lgtm

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2025
@github-ci-robot github-ci-robot merged commit d46d981 into huaweicloud:master Feb 10, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. LGTM /lgtm refactor size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants