Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B3 helm sucht kopf #431

Merged
merged 27 commits into from
Feb 2, 2025

Conversation

namkhanh-nguyen
Copy link
Contributor

Opening a Pull Request to Update your Project

I've started a documentation on how we should use the forking workflow here:

https://github.com/htw-imi-showtime/showtime-website/blob/documentation/doc/forking-workflow/index.md
(will not be merged to main due to file sizes)

Please follow these Steps & Guidelines for your Pull Request:

First, Check and Tick these Boxes:

[x] make sure that the hugo site build works and check the result visually.
[x] merge your local branch with upstream/main (see update doc)
[x] Deploy the Site on your github pages by activating the "Deploy Page using GH-Actions" Workflow in "gh-pages-action.yml"
[x] make sure that your PR contains only files / file changes within your project subdirectory.
[x] make sure that all your file names consist only of lower case letters, numbers, or [-_.] - with only one . for the file extension
[x] delete all unnecessary files from your PR (including cat.jpg and kitty.jpg)
[x] check the image file sizes. All Images have to be as small as possible. See ./doc/disk_usage.md about this issues, there's a script: ./bin/images-smaller.sh

Note that if you fail to do so, I may simply reduce the file sizes brute force using
the script above - WITHOUT CHECKING THE QUALITY

Fill out this Information:

  1. Change the PR Title to: (e.g. B0 - update techstack.md) and describe your changes:

  2. URL of your Preview Site Containing the Changes:

  3. When did your Project Supervisor review your changes? (Date/Note or require review for PR):

  4. If your disk usage exceeds 500K, provide a reason while you want to include so many images or why certain images need to be that big:

IMPORTANT: if you run into trouble / If the checks fail...

  • if you cannot figure out why a check fails or you think that it may be wrong,
    don't hesitate to contact me! (e.g. by requesting a review and commenting in the pr)

  • run the checks locally with:

    ./bin/check-project-update-pr/run-all.sh <project_id>

All good?

If all checks run successfully the PR will be reviewed and, if no
further changes are requested, merged and closed.
(this is the time to update and start a new branch!)

More Information

We are using the Forking Workflow.

@namkhanh-nguyen
Copy link
Contributor Author

@bkleinen wir brauchen die Changes zu mergen

@bkleinen
Copy link
Contributor

@bkleinen wir brauchen die Changes zu mergen

bis zur Release-Train deadline morgen abend ist ja noch etwas Zeit -

  • website_link meint einen Link zu einer Webseite auf der Informationen über das Projekt stehen.
    Ihr link ist vermutlich ein demo_link - oder evtl. auch ein app_link, das können Sie aber auch nach der Showtime noch von demo zu app ändern ggfs.

  • Ich hatte mehrfach gesagt das ich keine unkommentierten Iconwüsten haben möchte. Und ein "Tech Stack" ist das ohnehin nicht.

  • We collaborated with #HelmSuchtKopf, -> gibt es hier einen link? dann gerne setzen.

@bkleinen bkleinen merged commit 09df830 into htw-imi-showtime:main Feb 2, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants