-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error patches #63
Merged
Merged
Error patches #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both types are now closer to `io::ErrorKind` and `Box<dyn Error>`.
Uses our new crate error type everywhere instead of io::Error.
This allows Error to work with `?` in cases where a `Box<dyn Error>` is returned.
Addresses the last of @dignifiedquire's comments; this should be enough to pass the review!
dignifiedquire
approved these changes
Jan 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
Error
andErrorKind
types to contain aStatusCode
field that can be used to set a status code. This will help us make progress on:Exception
toError
. surf#113Exception
toError
cont. surf#133Additionally we can now cast any
Error + Send + Sync
to anhttp_types::Error
, with support for downcasting and traversing error chains.Changes
Error
andErrorKind
io::Error
withhttp_types::Error
Todos
todo!
sParseError
typesbail!
,ensure!
andformat_err!
macros