Transit changes #73
Open
Transit changes #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSmedal
reviewed
Aug 5, 2021
| @@ -0,0 +1,10 @@ | |||
| { | |||
There was a problem hiding this comment.
Why are we putting this in classes/includes/ instead of the root?
MSmedal
reviewed
Aug 5, 2021
MSmedal
reviewed
Aug 5, 2021
| @@ -754,7 +886,7 @@ public function scripts() | |||
| $scripts = array( | |||
| array( | |||
| 'handle' => 'securesubmit.js', | |||
| 'src' => 'https://api.heartlandportico.com/SecureSubmit.v1/token/2.1/securesubmit.js', | |||
| 'src' => 'https://api2.heartlandportico.com/securesubmit.v1/token/gp-1.6.0/globalpayments.js', | |||
There was a problem hiding this comment.
let's update to the latest: https://js.globalpay.com/v1/globalpayments.js
MSmedal
reviewed
Aug 5, 2021
| return array( | ||
| array( | ||
| 'name' => "avs_reject_conditions[A]", | ||
| 'label' => __('Address matches, zip No Match', $this->_slug), |
There was a problem hiding this comment.
let's add the response code in the label like we did in WooCommerce
MSmedal
reviewed
Aug 5, 2021
MSmedal
requested changes
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Admin and Front end changes for TransIT, AVS/CVS Rejection conditions