Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

458/450/RefactorVMPages #458

Merged
merged 13 commits into from
Mar 13, 2019
Merged

458/450/RefactorVMPages #458

merged 13 commits into from
Mar 13, 2019

Conversation

bdaase
Copy link
Contributor

@bdaase bdaase commented Mar 9, 2019 •
edited
Loading

Fixes #448, also closes #450.

@bdaase bdaase added the WIP work is still in progess for this PR label Mar 9, 2019
@bdaase bdaase added Review Required and removed WIP work is still in progess for this PR labels Mar 9, 2019
@bdaase bdaase self-assigned this Mar 9, 2019
@bdaase bdaase added WIP work is still in progess for this PR and removed Review Required labels Mar 9, 2019
@bdaase bdaase added Review Required and removed WIP work is still in progess for this PR labels Mar 9, 2019
@bdaase bdaase changed the title Rename tables on dashboard, remove actions 458/450/RefactorVMPages Mar 9, 2019
chrisma
chrisma requested changes Mar 11, 2019
View reviewed changes
Copy link
Contributor

@chrisma chrisma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

app/views/vms/_running_vm_buttons.erb Outdated Show resolved Hide resolved
spec/views/vms/index.html.erb_spec.rb Show resolved Hide resolved
@chrisma chrisma mentioned this pull request Mar 12, 2019
Open
chrisma
chrisma approved these changes Mar 12, 2019
View reviewed changes
Copy link
Contributor

@chrisma chrisma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay. Tests should be refactored in a separate PR regarding #468

@bdaase
Copy link
Contributor Author

bdaase commented Mar 13, 2019

Looks okay. Tests should be refactored in a separate PR regarding #468

Nice!

@bdaase bdaase merged commit c59a149 into dev Mar 13, 2019
@bdaase bdaase deleted the 448/refactorDashboard branch March 13, 2019 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisma chrisma chrisma approved these changes

@BraunTom BraunTom Awaiting requested review from BraunTom

@krichly krichly Awaiting requested review from krichly

@LeonMatthes LeonMatthes Awaiting requested review from LeonMatthes

@rteusner rteusner Awaiting requested review from rteusner

Assignees

@bdaase bdaase

Labels
Review Required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactoring VMs index page Refactoring Dashboard User Interface
2 participants
@bdaase @chrisma