Fix retrieval of package name for a method in Pharo 12 #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 29, 2024 15:40
… when methods of a Trait are passed through SCIPharo12CodeCoverage class>>#packageNameForMethod:
|
Since removing the method metadata breaks loading for platforms as old as Pharo 3 (even though the package is not for Pharo 3), I reverted the metadata changes. I would recommend to drop those old Pharo versions for the future ;-) |
|
The build failed because of a download failure. I cannot restart the build. |
|
@fniephaus I cannot re-run the action jobs on this PR. Could you? All the runs should be green again but the previous built failed because of a download failure. |
|
sure, no problem |
|
It looks like this is working well. |
fniephaus
approved these changes
Apr 8, 2024
jbrichau
pushed a commit
to SeasideSt/Seaside
that referenced
this pull request
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash in Pharo 12 when code coverage reporting is enabled and when methods of a Trait are passed through
SCIPharo12CodeCoverage class>>#packageNameForMethod:Without the fix: https://github.com/SeasideSt/Seaside/actions/runs/8442597789/job/23124347278
With the fix: https://github.com/SeasideSt/Seaside/actions/runs/8482174261
I also notice metadata is removed. Since the changes are in a Pharo-specific package, I left them in. If you want me to revert those changes and keep metadata, let me know.