fix for #718, #714, #711, #710 #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added the fix for #710 |
sneharai4
approved these changes
Aug 27, 2019
|
@bhagyashree-sarawate Code looks good to me. |
sneharai4
requested changes
Aug 27, 2019
| self.tgt_bkend_config.hpe3par_snapcpg = \ | ||
| self._extract_remote_cpgs( | ||
| self.tgt_bkend_config.snap_cpg_map) | ||
| if self.tgt_bkend_config.snap_cpg_map: |
There was a problem hiding this comment.
@bhagyashree-sarawate As per https://github.com/hpe-storage/python-hpedockerplugin/blob/master/docs/active-passive-based-replication.md both cpg_map and snap_cpg_map in replication_device section are mandatory.
But as per code, when user doesn't give snap_cpg_map, cpg_map is used as snap_cpg_map.
Please fix the documentation for this.
sneharai4
requested changes
Sep 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
Fixes for #718,#714, #711
Please review
Regards
Bhagyashree Sarawate