Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor corrections: Solar charger - Victron #1623

Merged
merged 3 commits into from
Feb 14, 2025
Merged

Minor corrections: Solar charger - Victron #1623

merged 3 commits into from
Feb 14, 2025

Conversation

SW-Niko
Copy link

@SW-Niko SW-Niko commented Feb 10, 2025 •
edited
Loading

Changes:

  • Removed case 246. This case is not used by solar charger, see Victron documentation for more details
  • Add of unit information on function description
  • Optional returning functions getYieldTotal() and getYieldDay() never return std::nullopt
  • getPanelPowerWatts() cast explicit from float into int32_t and implizit from int32_t into uint16_t

currently no problem at all. Just to avoid problems in future.

@SW-Niko
Copy link
Author

SW-Niko commented Feb 10, 2025

Hello @AndreasBoehm,
I actually found the things by chance. Please double check.

AndreasBoehm
AndreasBoehm requested changes Feb 10, 2025
View reviewed changes
src/solarcharger/victron/Stats.cpp Outdated Show resolved Hide resolved
src/solarcharger/victron/Stats.cpp Outdated Show resolved Hide resolved
src/solarcharger/victron/Stats.cpp Show resolved Hide resolved
@SW-Niko
Copy link
Author

SW-Niko commented Feb 13, 2025

Test run done. No issues detected.

@AndreasBoehm AndreasBoehm merged commit 337b69e into hoylabs:development Feb 14, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreasBoehm AndreasBoehm AndreasBoehm approved these changes

@schlimmchen schlimmchen schlimmchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SW-Niko @AndreasBoehm @schlimmchen