Add Test to confirm AY2324S1-CS2103T-F12-4#122 AY2324S1-CS2103T-F12-4…

…#133 are fixed
howenc · Nov 7, 2023 · 0cbc248 · 0cbc248
1 parent 5ec7187
commit 0cbc248
Show file tree

Hide file tree

Showing 2 changed files with 59 additions and 1 deletion.
diff --git a/src/test/java/seedu/address/logic/parser/FindMeetingCommandParserTest.java b/src/test/java/seedu/address/logic/parser/FindMeetingCommandParserTest.java
@@ -82,6 +82,10 @@ public void parse_validArgs_returnsFilterMeetingCommand() {
     public void parse_inValidArgsTime_throwsParseException() {
         assertParseFailure(parser, " e/20.09.2023 1000 s/20.09.2023 1200",
                 MeetingTime.MESSAGE_CONSTRAINTS + "\n" + FindMeetingCommand.MESSAGE_USAGE);
+        assertParseFailure(parser, " s/20.09.2023 1200",
+                "Please input both start and end times" + "\n" + FindMeetingCommand.MESSAGE_USAGE);
+        assertParseFailure(parser, " e/20.09.2023 1000",
+                "Please input both start and end times" + "\n" + FindMeetingCommand.MESSAGE_USAGE);
     }
 
     /**

diff --git a/src/test/java/seedu/address/logic/parser/ParserUtilTest.java b/src/test/java/seedu/address/logic/parser/ParserUtilTest.java
@@ -12,6 +12,7 @@
 import static seedu.address.testutil.TypicalIndexes.INDEX_SECOND_PERSON;
 import static seedu.address.testutil.TypicalIndexes.INDEX_THIRD_PERSON;
 
+import java.time.LocalDateTime;
 import java.util.Arrays;
 import java.util.Collections;
 import java.util.HashSet;
@@ -38,8 +39,14 @@ public class ParserUtilTest {
     private static final String VALID_EMAIL = "[email protected]";
     private static final String VALID_TAG_1 = "friend";
     private static final String VALID_TAG_2 = "neighbour";
-
     private static final String WHITESPACE = " \t\r\n";
+    private static final String VALID_TIME = "02.10.2023 1000";
+    private static final String INVALID_TIME_1 = "02.10.2023  1000";
+    private static final String INVALID_TIME_2 = "02.10.29999 1000";
+    private static final String INVALID_TIME_3 = "02.10.2023 10000";
+    private static final String INVALID_TIME_4 = "02.15.2023 1000";
+    private static final String INVALID_TIME_5 = "78.10.2023 1000";
+    private static final String INVALID_TIME_6 = "02.10.2023 5555";
 
     @Test
     public void verifyNoArgs_argsPresent_throwsParseException() {
@@ -234,4 +241,51 @@ public void parseTags_collectionWithValidTags_returnsTagSet() throws Exception {
 
         assertEquals(expectedTagSet, actualTagSet);
     }
+
+    @Test
+    public void parseTime_null_throwsNullPointerException() {
+        assertThrows(NullPointerException.class, () -> ParserUtil.parseName((String) null));
+    }
+
+    @Test
+    public void parseTime_invalidValue0_throwsParseException() {
+        assertThrows(ParseException.class, () -> ParserUtil.parseContactTime("29.02.2023 1000"));
+        assertThrows(ParseException.class, () -> ParserUtil.parseMeetingTime("29.02.2023 1000"));
+    }
+
+    @Test
+    public void parseTime_invalidValue1_throwsParseException() {
+        assertThrows(ParseException.class, () -> ParserUtil.parseContactTime("30.02.2023 1000"));
+        assertThrows(ParseException.class, () -> ParserUtil.parseMeetingTime("30.02.2023 1000"));
+    }
+
+    @Test
+    public void parseTime_invalidValue2_throwsParseException() {
+        assertThrows(ParseException.class, () -> ParserUtil.parseContactTime("31.02.2023 1000"));
+        assertThrows(ParseException.class, () -> ParserUtil.parseMeetingTime("31.02.2023 1000"));
+    }
+
+    @Test
+    public void parseTime_invalidValue3_throwsParseException() {
+        assertThrows(ParseException.class, () -> ParserUtil.parseContactTime("31.04.2023 1000"));
+        assertThrows(ParseException.class, () -> ParserUtil.parseMeetingTime("31.04.2023 1000"));
+    }
+
+    @Test
+    public void parseTime_invalidValue4_throwsParseException() {
+        assertThrows(ParseException.class, () -> ParserUtil.parseContactTime(INVALID_TIME_1));
+        assertThrows(ParseException.class, () -> ParserUtil.parseMeetingTime(INVALID_TIME_2));
+        assertThrows(ParseException.class, () -> ParserUtil.parseContactTime(INVALID_TIME_3));
+        assertThrows(ParseException.class, () -> ParserUtil.parseMeetingTime(INVALID_TIME_4));
+        assertThrows(ParseException.class, () -> ParserUtil.parseContactTime(INVALID_TIME_5));
+        assertThrows(ParseException.class, () -> ParserUtil.parseMeetingTime(INVALID_TIME_6));
+    }
+
+    @Test
+    public void parseTime_validValueWithoutWhitespace_returnsName() throws Exception {
+        LocalDateTime expectedTime = LocalDateTime.of(2023, 10, 2, 10, 00);
+        assertEquals(expectedTime, ParserUtil.parseContactTime(VALID_TIME));
+        assertEquals(expectedTime, ParserUtil.parseMeetingTime(VALID_TIME));
+    }
+
 }