Implemented: Bulk API calls to add facility to group and to update facility to group on Manage Facilities page.(#339) #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cility to group on Manage Facilities page.(hotwax#339)
ymaheshwari1
requested changes
Feb 5, 2025
src/views/ManageFacilities.vue
Outdated
| })) | ||
| ) | ||
| try{ | ||
| const removeResponses = await FacilityService.updateFacilitiesToGroup({ |
There was a problem hiding this comment.
Suggested change
| const removeResponses = await FacilityService.updateFacilitiesToGroup({ | |
| const removeResponse = await FacilityService.updateFacilitiesToGroup({ |
src/views/ManageFacilities.vue
Outdated
| "facilityGroupId": this.facilityGroupId, | ||
| "facilityId": facility.facilityId, | ||
| "sequenceNum": facility.sequenceNum | ||
| })) |
There was a problem hiding this comment.
We should add a check to not make this api calls if there are no facilities to add/remove.
…lities to add/remove or change in sequence.(hotwax#339)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#339
Short Description and Why It's Useful
Contribution and Currently Important Rules Acceptance