Implemented: operating hours functionality on facility details page (#28) #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stomSchedule modal and operating hours popover (hotwax#28)
alsoK2maan
suggested changes
Nov 28, 2023
| this.store.dispatch('facility/fetchFacilityCalendar', { facilityId: this.facilityId }) | ||
| modalController.dismiss() | ||
| }, | ||
| async removeCalendarFromFacility() { |
There was a problem hiding this comment.
Call the service directly instead of wrapping in a function.
| <ion-list lines="none" v-if="isDailyTimingsChecked"> | ||
| <ion-item v-for="(day, index) in days" :key="index"> | ||
| <ion-label> | ||
| <p>{{ translate(day) }}</p> |
There was a problem hiding this comment.
Make sure all the days are added in the translations file.
…fetching calendar timings with calendar list (hotwax#28)
amansinghbais
changed the title
ravilodhi
reviewed
Nov 29, 2023
src/store/modules/util/actions.ts
Outdated
| try { | ||
| resp = await UtilService.fetchCalendars({ | ||
| inputFields: { | ||
| facilityId: payload.facilityId |
There was a problem hiding this comment.
Remove this facility filter.
src/store/modules/util/actions.ts
Outdated
|
|
||
| resp = await UtilService.fetchCalendarWeekTimings({ | ||
| inputFields: { | ||
| calendarWeekId: payload.calendarWeekId |
There was a problem hiding this comment.
Here we need to fetch calendar weeks based on the calenders fetched in the first step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes: #28
Short Description and Why It's Useful
Implemented operating hours functionality in facility details page.
Screenshots of Visual Changes before/after (If There Are Any)
Contribution and Currently Important Rules Acceptance