Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: When the modal is reopened, no option should appear pre-selected unless it was previously saved(#359) #360

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

R-Sourabh
Copy link
Contributor

Related Issues

#359

Short Description and Why It's Useful

  • Handled the case when, after opening the modal, the user selects any facility and closes the modal without saving, the selectedFacility gets updated. To fix this, I am emptying the selectedFacility on @didDismiss.
  • Updating the selectedFacilityId ref on @didPresent to set the current facility correctly.

Screenshots of Visual Changes before/after (If There Are Any)

Is the changes contains any breaking change?

If there are any breaking change include those in the release notes file

  • Yes
  • No

Contribution and Currently Important Rules Acceptance

@ymaheshwari1 ymaheshwari1 merged commit ff5f02c into hotwax:main Jan 29, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants