Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add web components definition back #47

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Add web components definition back #47

merged 1 commit into from
Aug 7, 2024

Conversation

emi420
Copy link
Collaborator

@emi420 emi420 commented Aug 7, 2024

This fixes #46 , enabling back the components definition.

@JoltCode can you please take a look? I'm not sure if you commented that for some reason.

CC @spwoodcock

@emi420 emi420 requested a review from JoltCode August 7, 2024 17:28
@JoltCode
Copy link
Collaborator

JoltCode commented Aug 7, 2024

Yeah it was commented because this was causing a runtime error in Storybook, and this was the only thing which seemed to fix that at the time, but then this being commented out was breaking the component decelerations.

Copy link
Collaborator

@JoltCode JoltCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now we should uncomment - we're looking at changing our build pipeline which should resolve this "properly" in the future.

@spwoodcock spwoodcock merged commit 12ad2b0 into main Aug 7, 2024
1 of 2 checks passed
@spwoodcock spwoodcock deleted the fix/storybook branch August 7, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storybook's stories are not working
3 participants