Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove convex hull to avoid getting features outside aoi #41

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

Sujanadh
Copy link
Contributor

@Sujanadh Sujanadh commented Dec 9, 2024

Issue

Description

This PR fixes the issue of generating osm data extracts even outside of AOI. The problem was due to use of convex hull to create a Polygon from MultiPolyon which creates a convex polygon deviating from original polygon structure. Details are described on the mentioned issue.

@github-actions github-actions bot added the bug Something isn't working label Dec 9, 2024
Copy link
Member

@spwoodcock spwoodcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@spwoodcock spwoodcock merged commit 1ba29c0 into hotosm:main Dec 9, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants