Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default language in settings tab if not present #336

Merged
merged 7 commits into from
Jan 21, 2025

Conversation

Sujanadh
Copy link
Contributor

Updates:

  • Added portuguese translation label of geometry and survey group in mandatory fields
  • Added default language in settings tab if not present
  • Avoid overwriting the settings tab instead add/update mandatory fields in them, such as form_id, version, and form_title

Related Issues:

@spwoodcock
Copy link
Member

This is a great improvement 👍

Currently I don't think we handle the standard label field without any language, but we can address that later

@spwoodcock spwoodcock merged commit ab8a073 into main Jan 21, 2025
4 of 6 checks passed
@spwoodcock spwoodcock deleted the feat/add-portugese-translation branch January 21, 2025 11:19
@Sujanadh
Copy link
Contributor Author

We do handle the standard label field, if it is only label field without any language then we add english(en) by default, label -> label::english(en)

@spwoodcock
Copy link
Member

spwoodcock commented Jan 22, 2025

Oh cool, I missed that! 😄

https://github.com/hotosm/osm-fieldwork/blob/main/osm_fieldwork%2Fupdate_xlsform.py#L125-130

Good approach 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants