Allow the XLSForm new_feature question geometry type to be configurable #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Sujanadh
reviewed
Jan 10, 2025
| { | ||
| "type": geom_field, | ||
| "name": "new_feature", | ||
| "label::english(en)": "Alternatively, take a gps coordinates of a new feature", |
There was a problem hiding this comment.
also need to update labels
There was a problem hiding this comment.
Ah of course, thanks, that label doesn't make sense anymore.
It would be nice to have it tweaked based on geometry type, but that increases the translation burden.
Perhaps just
'Please draw a new geometry'
would work for all geom types
There was a problem hiding this comment.
yeah we can generalize it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new_geom_typeto theappend_mandatory_fieldsfunction.POINT,POLYGON,LINESTRING.new_featurequestion type based on that.Note we don't actually use the question type in ODK mostly. But this just inform ODK for the geometry type to be stored in the submission.
Also note the tests are all failing currently due to a dockerfile issue, so we can't run the test suite: #328