Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Registry & Account as Components and add upgradable to Registry #35

Merged
merged 6 commits into from
Mar 1, 2024

Conversation

cloudvenger
Copy link
Contributor

@cloudvenger cloudvenger commented Mar 1, 2024

Description

  • Rewrite Account with Components architecture
  • Create default Account (Preset)
  • Add Upgradable Components from OpenZepplin
  • Add Upgradable to Account

Point of precision for improvement: If we are agreed, we could import generic Components from OpenZepplin like Upgradable, Ownable, Accesscontrol, etc....

Remains to be done

We should create specific Issues for this points :

  • Upgrade to Cairo 2.5.4 and sn-foundry v0.18
  • Adding Ownable and Access Control Components and integrate them in Account and Registry

Issues resolved

Fix #31

working hours

10 hours

src/registry.cairo Outdated Show resolved Hide resolved
@Darlington02 Darlington02 merged commit 06b7d14 into horuslabsio:main Mar 1, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite Account Contract
2 participants