feat: add createApp without default routes #85
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user implementation includes
import { createApp } from "honox/server"
, all routes are included in the bundle by the hardcodedimport.meta.glob
.Even if the user gives the option of
createApp
to overwrite it, the hardcoded part is still there and will not be removed by DCE.With this change,
import { createApp } from "honox/server/base"
can be used to bypass the hardcoded parts and control all bundled routes by the options we give.This change also allows builds that only return dynamic routes from Cloudflare Workers, without unnecessary routes which is already SSGed.
(We still need to work, due to current
@hono/vite-cloudflare-pages
cannot serve SSGed files )