feat: enable placing islands anywhere #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was thinking of making it based on @liltechnomancer 's code, but there has been a big difference. So, I can't add @liltechnomancer as a co-author, but your comment was helpful! |
|
Hi @usualoma ! Could you review this one? |
usualoma
reviewed
May 11, 2024
src/client/client.ts
Outdated
| ...import.meta.glob('/app/routes/**/_[a-zA-Z0-9[-]+.island.(tsx|ts)'), | ||
| ...import.meta.glob('/app/islands/**/[a-zA-Z0-9-]+.(tsx|ts)'), | ||
| ...import.meta.glob('/app/**/_[a-zA-Z0-9-]+.island.(tsx|ts)'), | ||
| ...import.meta.glob('/app/**/$[a-zA-Z0-9-]+.(tsx|ts)'), |
There was a problem hiding this comment.
It has nothing to do with this PR change, In matchIslandComponentId(), only .tsx matches (.ts does not), so I think only .tsx` should be used here as well.
There was a problem hiding this comment.
You are right! It should be only .tsx and it's not a problem if it does not support .ts.
|
Thanks @usualoma ! I've fixed it. I'll merge this right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, we can put island components anywhere instead of under
/app/routesor/app/islands. For example, the components placed like the following will be treated as islands./app/components/$counter.tsx/app/components/_counter.island.tsxIn addition, I've added the following changes:
^/islandsor specify the path if passing the option.Fixes #159