fix(types): correct app.on(method,path[],middleware,handler) type (#…

…3802)
honojs · Jan 5, 2025 · 100745a · 100745a
1 parent 5af7b4f
commit 100745a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/types.test.ts b/src/types.test.ts
@@ -277,6 +277,14 @@ describe('OnHandlerInterface', () => {
     }
     type verify = Expect<Equal<Expected, Actual>>
   })
+
+  test('app.on(method, path[], middleware, handler) should not throw a type error', () => {
+    const middleware: MiddlewareHandler<{ Variables: { foo: string } }> = async () => {}
+    app.on('GET', ['/a', '/b'], middleware, (c) => {
+      expectTypeOf(c.var.foo).toEqualTypeOf<string>()
+      return c.json({})
+    })
+  })
 })
 
 describe('TypedResponse', () => {

diff --git a/src/types.ts b/src/types.ts
@@ -1745,10 +1745,10 @@ export interface OnHandlerInterface<
   ): HonoBase<E, S & ToSchema<string, MergePath<BasePath, P>, I, MergeTypedResponse<R>>, BasePath>
 
   // app.on(method | method[], path[], ...handlers[])
-  <I extends Input = BlankInput, R extends HandlerResponse<any> = any>(
+  <I extends Input = BlankInput, R extends HandlerResponse<any> = any, E2 extends Env = E>(
     methods: string | string[],
     paths: string[],
-    ...handlers: H<E, any, I, R>[]
+    ...handlers: H<E2, any, I, R>[]
   ): HonoBase<E, S & ToSchema<string, string, I, MergeTypedResponse<R>>, BasePath>
 }