feat: add name as projectName to cloned project template package.json
#48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yusukebe
approved these changes
Jun 10, 2024
|
Added requested changes |
|
Thank you for updating it. But still, I got the error when choosing the
Can you see it? |
|
Got it, my bad I used a different logic for checking for package json.
…On Thu, 13 Jun, 2024, 7:54 am Yusuke Wada, ***@***.***> wrote:
@BRAVO68WEB <https://github.com/BRAVO68WEB>
Thank you for updating it. But still, I got the error when choosing the
deno:
***@***.*** (view on web)
<https://github.com/honojs/create-hono/assets/10682/40c308e2-f766-42e2-a760-1a89f9b70ec3>
Can you see it?
—
Reply to this email directly, view it on GitHub
<#48 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJ4HJV4U3YW33EK4F6JYYJLZHD7HBAVCNFSM6AAAAABJBGPAH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRUGIZTCMRWGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Great! Let's go with it. Thank you for the nice feature! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nameas projectName to cloned project template package.json