Skip to content

Commit

Permalink
perf: add PHP 8.4 to test matrix (#146)
Browse files Browse the repository at this point in the history
* Let Honeybagder Laravel play nice with PHP 8.4

* Add PHP 8.4 to run-tests.yml
  • Loading branch information
the-pulli authored Dec 17, 2024
1 parent 99b690e commit a57cd79
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/run-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ jobs:
fail-fast: false
matrix:
php:
- 8.4
- 8.3
- 8.2
- 8.1
Expand All @@ -23,9 +24,11 @@ jobs:
- lowest
- latest
include:
- {php: '8.4', laravel: '11.*'}
- {php: '8.3', laravel: '11.*'}
- {php: '8.2', laravel: '11.*'}

- {php: '8.4', laravel: '10.*'}
- {php: '8.3', laravel: '10.*'}
- {php: '8.2', laravel: '10.*'}
- {php: '8.1', laravel: '10.*'}
Expand Down
2 changes: 1 addition & 1 deletion src/HoneybadgerLaravel.php
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public static function make(array $config): Reporter
], $config));
}

public function notify(Throwable $throwable, Request $request = null, array $additionalParams = []): array
public function notify(Throwable $throwable, ?Request $request = null, array $additionalParams = []): array
{
$this->setRouteActionAndUserContext($request ?: request());

Expand Down
2 changes: 1 addition & 1 deletion src/Installer.php
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public function shouldPublishConfig(): bool
/**
* {@inheritdoc}
*/
public function publishLumenConfig(string $stubPath = null): bool
public function publishLumenConfig(?string $stubPath = null): bool
{
if (! is_dir(base_path('config'))) {
mkdir(base_path('config'));
Expand Down

0 comments on commit a57cd79

Please sign in to comment.