Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove unused variable from dataset module [DEVOP-5596] #45

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/terratest.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: "Terratest GitHub Action"

Check failure on line 1 in .github/workflows/terratest.yaml

View workflow job for this annotation

GitHub Actions / checkov

CKV2_GHA_1: "Ensure top-level permissions are not set to write-all"
on:
pull_request:
branches: [test, dev, qa, prod, main]
Expand All @@ -19,9 +19,9 @@
with:
submodules: true
- name: Set up Go
uses: actions/setup-go@v5
uses: actions/setup-go@v4
with:
go-version: 1.20
go-version: 1.23
id: go
- name: Run 'go test -v -timeout 60m'
run: |
Expand Down
5 changes: 2 additions & 3 deletions examples/gcp_bigquery_big_lake_table/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@ module "bigquery_dataset" {
description = "dataset's description"
// location of the resource which here is Jakarta
location = "asia-southeast2"
// email of the owner of the account, can be either user or service account
owner_email = google_service_account.owner.email
// indicate the Google project that this resource will be created in
google_project = var.google_project
}
Expand Down Expand Up @@ -97,12 +95,13 @@ module "big_lake_table" {
]
}

#tfsec:ignore:google-storage-enable-ubla
#tfsec:ignore:google-storage-bucket-encryption-customer-key
resource "google_storage_bucket" "big_lake_data_source" {
#checkov:skip=CKV_GCP_114:This is an ephemeral example not meant for real-world usage.
#checkov:skip=CKV_GCP_29:This is an ephemeral example not meant for real-world usage.
#checkov:skip=CKV_GCP_62:This is an ephemeral example not meant for real-world usage.
#checkov:skip=CKV_GCP_78:This is an ephemeral example not meant for real-world usage.

location = local.google_region_jakarta
name = "big_lake_data_source-${local.file_extension}-${random_id.big_lake_data_source_random_id.hex}"
}
Expand Down
1 change: 0 additions & 1 deletion examples/gcp_bigquery_cloudsql_connection/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ module "bigquery_dataset" {
name = "dataset_${random_id.random_id.hex}"
description = "dataset's description"
location = "asia-southeast2"
owner_email = google_service_account.owner.email
google_project = var.google_project
}

Expand Down
2 changes: 0 additions & 2 deletions examples/gcp_bigquery_dataset/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@ module "bigquery_dataset" {
description = "dataset's description"
// location of the resource which here is Jakarta
location = "asia-southeast2"
// email of the owner of the account, can be either user or service account
owner_email = google_service_account.owner.email
// indicate the Google project that this resource will be created in
google_project = var.google_project
}
Expand Down
2 changes: 0 additions & 2 deletions examples/gcp_bigquery_dataset_iam_policy/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@ module "create_bigquery_dataset" {
description = "dataset's description"
// location of the resource which here is Jakarta
location = "asia-southeast2"
// email of the owner of the account, can be either user or service account
owner_email = google_service_account.owner.email
// indicate the Google project that this resource will be created in
google_project = var.google_project
}
Expand Down
2 changes: 0 additions & 2 deletions examples/gcp_bigquery_table/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@ module "bigquery_dataset" {
description = "dataset's description"
// location of the resource which here is Jakarta
location = "asia-southeast2"
// email of the owner of the account, can be either user or service account
owner_email = google_service_account.owner.email
// indicate the Google project that this resource will be created in
google_project = var.google_project
}
Expand Down
1 change: 0 additions & 1 deletion examples/gcp_bigquery_view/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ module "bigquery_dataset" {
name = "dataset_${random_id.random_id.hex}"
description = "Used for testing gcp_bigquery_view"
location = "asia-southeast2"
owner_email = google_service_account.owner.email
google_project = var.google_project
}

Expand Down
3 changes: 1 addition & 2 deletions modules/gcp_bigquery_dataset/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,9 @@ No modules.
| Name | Description | Type | Default | Required |
|------|-------------|------|---------|:--------:|
| <a name="input_description"></a> [description](#input\_description) | A user-friendly description of the dataset | `string` | n/a | yes |
| <a name="input_google_project"></a> [google\_project](#input\_google\_project) | GCP project name that this dataset will be creating in. | `string` | n/a | yes |
| <a name="input_google_project"></a> [google\_project](#input\_google\_project) | GCP project name that this dataset will be creating in. Defaults to Google provider project | `string` | `null` | no |
| <a name="input_location"></a> [location](#input\_location) | The geographic location where the dataset should reside. See official docs. <br>There are two types of locations, regional or multi-regional. A regional location is a specific geographic place, such as Tokyo, and a multi-regional location is a large geographic area, such as the United States, that contains at least two geographic places. <br>The default value is multi-regional location US. Changing this forces a new resource to be created. | `string` | n/a | yes |
| <a name="input_name"></a> [name](#input\_name) | A descriptive name for the dataset | `string` | n/a | yes |
| <a name="input_owner_email"></a> [owner\_email](#input\_owner\_email) | An email address of a user to grant access to. For example [email protected] | `string` | n/a | yes |

## Outputs

Expand Down
5 changes: 0 additions & 5 deletions modules/gcp_bigquery_dataset/inputs.tf
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,3 @@ variable "location" {
type = string
description = "The geographic location where the dataset should reside. See official docs. \nThere are two types of locations, regional or multi-regional. A regional location is a specific geographic place, such as Tokyo, and a multi-regional location is a large geographic area, such as the United States, that contains at least two geographic places. \nThe default value is multi-regional location US. Changing this forces a new resource to be created."
}

variable "owner_email" {
type = string
description = "An email address of a user to grant access to. For example [email protected]"
}
Loading