Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: csv_options should be only used when source_format is CSV #40

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

HeshamMeneisi
Copy link
Contributor

@HeshamMeneisi HeshamMeneisi commented Feb 1, 2024

Pull Request Submission Checklist

Please confirm that you have done the following before requesting reviews:

  • I have confirmed that the PR type is appropriate for the change I am making according to the Honest Pull Request and Commit Message Naming Conventions.
  • I have typed an adequate description that explains why I am making this change.
  • I have installed and run standard pre-commit hooks that lints and validates my code.

Description

  • csv_options should be only expected when source_format is CSV.

This change is Reviewable

@HeshamMeneisi HeshamMeneisi requested a review from a team as a code owner February 1, 2024 08:25
@HeshamMeneisi HeshamMeneisi requested a review from MXfive February 1, 2024 08:25
@honestbank-bot
Copy link
Contributor

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖Success! The configuration is valid.

Terraform Plan 📖failure

Show Plan

Pusher: @HeshamMeneisi, Action: pull_request, Working Directory: ``, Workflow: terraform

@HeshamMeneisi HeshamMeneisi merged commit 2f52baf into main Feb 1, 2024
6 checks passed
@HeshamMeneisi HeshamMeneisi deleted the hesham/da-2679-fix-the-csv_options-issue branch February 1, 2024 08:31
Copy link

github-actions bot commented Feb 1, 2024

🎉 This PR is included in version 1.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants