Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change the default consumer session timeout to 30 seconds #105

Merged
merged 1 commit into from
Oct 10, 2024
Merged

feat: change the default consumer session timeout to 30 seconds #105

merged 1 commit into from
Oct 10, 2024

Conversation

cyberhck
Copy link
Contributor

@cyberhck cyberhck commented Oct 10, 2024 •
edited by jai
Loading

Pull Request Submission Checklist

Please confirm that you have done the following before requesting reviews:

  • I have confirmed that the PR type is appropriate for the change I am making according to
    the Honest Pull Request and Commit Message Naming Conventions.
  • I have typed an adequate description that explains why I am making this change.
  • I have installed and run standard pre-commit hooks that lints and validates my code.

Description

  • Currently, the default consumer session timeout is only 6 seconds, which can trigger a early rebalance if the message processing takes more than 6 seconds.
  • confluent kafka recommends a good default of 30 seconds.
  • This PR changes the default to 30 seconds.

closes #104

This change is Reviewable

@cyberhck cyberhck requested review from a team as code owners October 10, 2024 00:35
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@cyberhck cyberhck merged commit 283ac99 into main Oct 10, 2024
10 of 11 checks passed
@cyberhck cyberhck deleted the cyberhck-patch-2 branch October 10, 2024 03:44
@honestbank-bot
Copy link
Contributor

🎉 This PR is included in version 1.15.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poom poom poom approved these changes

@taras-zak taras-zak taras-zak approved these changes

@misranitin misranitin Awaiting requested review from misranitin misranitin is a code owner automatically assigned from honestbank/backend-engineers

@justdarwin justdarwin Awaiting requested review from justdarwin justdarwin is a code owner automatically assigned from honestbank/honestbank-engineers

Assignees
No one assigned
Labels
hacktoberfest-accepted released size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change the default ConsumerSessionTimeoutMs to 30 seconds
4 participants
@cyberhck @honestbank-bot @poom @taras-zak