Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use atomic boolean for continue flag #103

Merged
merged 1 commit into from
Oct 8, 2024
Merged

refactor: use atomic boolean for continue flag #103

merged 1 commit into from
Oct 8, 2024

Conversation

cyberhck
Copy link
Contributor

@cyberhck cyberhck commented Oct 8, 2024 •
edited by su-astika
Loading

Pull Request Submission Checklist

Please confirm that you have done the following before requesting reviews:

  • I have confirmed that the PR type is appropriate for the change I am making according to
    the Honest Pull Request and Commit Message Naming Conventions.
  • I have typed an adequate description that explains why I am making this change.
  • I have installed and run standard pre-commit hooks that lints and validates my code.

Description

  • we used atomic int a while ago to handle concurrency issues, since go 1.19 we have atomic boolean.
  • This PR changes the flag to use atomic boolean.

closes #74

This change is Reviewable

@cyberhck cyberhck requested review from a team as code owners October 8, 2024 03:44
@cyberhck cyberhck force-pushed the nishchal/use-atomic-boolean branch from 53da72d to 18338c8 Compare October 8, 2024 03:58
@cyberhck
Copy link
Contributor Author

cyberhck commented Oct 8, 2024

@poom since you had opened #74 please take a look 🙂

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@cyberhck cyberhck merged commit 9c742d7 into main Oct 8, 2024
9 of 10 checks passed
@cyberhck cyberhck deleted the nishchal/use-atomic-boolean branch October 8, 2024 04:48
@honestbank-bot
Copy link
Contributor

🎉 This PR is included in version 1.15.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poom poom poom approved these changes

@su-astika su-astika su-astika approved these changes

@onkarbanerjee onkarbanerjee Awaiting requested review from onkarbanerjee onkarbanerjee is a code owner automatically assigned from honestbank/backend-engineers

@thadchais thadchais Awaiting requested review from thadchais thadchais is a code owner automatically assigned from honestbank/honestbank-engineers

Assignees
No one assigned
Labels
hacktoberfest-accepted released size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: use atomic boolean instead int
4 participants
@cyberhck @honestbank-bot @poom @su-astika