Fixed bad client validation of saveAttribute;

homebase-id · Feb 2, 2024 · af5d6ba · af5d6ba
1 parent 05527a8
commit af5d6ba
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/packages/js-lib/src/core/DriveData/SecurityHelpers.ts b/packages/js-lib/src/core/DriveData/SecurityHelpers.ts
@@ -102,7 +102,12 @@ export const decryptJsonContent = async (
   fileMetaData: FileMetadata,
   keyheader: KeyHeader | undefined
 ): Promise<string> => {
-  if (!keyheader || !fileMetaData.appData.content) return fileMetaData.appData.content;
+  if (
+    !keyheader ||
+    !fileMetaData.appData.content ||
+    typeof fileMetaData.appData.content === 'object'
+  )
+    return fileMetaData.appData.content;
 
   try {
     const cipher = base64ToUint8Array(fileMetaData.appData.content);

diff --git a/packages/js-lib/src/profile/AttributeData/AttributeDataProvider.ts b/packages/js-lib/src/profile/AttributeData/AttributeDataProvider.ts
@@ -469,7 +469,8 @@ export const saveAttribute = async (
 
     if (keyHeader && existingDefaultPayload?.iv) {
       keyHeader.iv = existingDefaultPayload.iv;
-    } else if (keyHeader) {
+    } else if (keyHeader && !shouldEmbedContent) {
+      // Fail if we can't find the IV for the existing default payload (and we need it)
       throw new Error('We failed to find the IV of an attribute to upload with');
     }