Better video playback (#67)

* Add support to play inline; * Easy changes on PostComposer;
homebase-id · Jan 23, 2024 · 73ee9b3 · 73ee9b3
1 parent 8efc648
commit 73ee9b3
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 10 deletions.
diff --git a/packages/feed-app/src/components/SocialFeed/PostComposer.tsx b/packages/feed-app/src/components/SocialFeed/PostComposer.tsx
@@ -225,6 +225,7 @@ const PostComposer = ({
               channel && setChannel(channel);
               setCustomAcl(acl);
             }}
+            excludeMore={true}
             ref={selectRef}
           />
           <ActionButton
@@ -319,7 +320,7 @@ export const ChannelOrAclSelector = React.forwardRef(
         e.target.value = getDefaultChannel();
       } else if (e.target.value === 'custom') {
         setIsCustomAclOpen(true);
-        e.target.value = getPublicChannel();
+        // e.target.value = getPublicChannel();
       } else {
         onChange(
           channels.find((chnl) =>
@@ -346,15 +347,18 @@ export const ChannelOrAclSelector = React.forwardRef(
           ref={ref}
           disabled={disabled}
         >
-          {channels.map((channel) => (
-            <option
-              value={channel.fileMetadata.appData.uniqueId}
-              key={channel.fileMetadata.appData.uniqueId}
-            >
-              {channel.fileMetadata.appData.content.name}
-            </option>
-          ))}
-          {!excludeMore && !excludeCustom ? (
+          <optgroup label={t('Channels')}>
+            {channels.map((channel) => (
+              <option
+                value={channel.fileMetadata.appData.uniqueId}
+                key={channel.fileMetadata.appData.uniqueId}
+              >
+                {channel.fileMetadata.appData.content.name}
+              </option>
+            ))}
+          </optgroup>
+
+          {!excludeMore || !excludeCustom ? (
             <optgroup label={t('Advanced')}>
               {!excludeMore ? (
                 <option value={'more'} key={'more'}>

diff --git a/packages/ui-lib/src/components/OdinVideo/OdinVideo.tsx b/packages/ui-lib/src/components/OdinVideo/OdinVideo.tsx
@@ -98,6 +98,7 @@ export const OdinVideo = (videoProps: OdinVideoProps) => {
       data-globaltransitid={globalTransitId}
       data-filekey={fileKey}
       data-playback={playback}
+      playsInline={true}
     >
       {isInView && playback !== undefined ? (
         playback === 'encrypted-mse' ? (