remove local tag operations to a diff class

src/core/Odin.Core.Storage/Database/Identity/IdentityDatabase.cs

@@ -107,9 +107,6 @@ public class IdentityDatabase(ILifetimeScope lifetimeScope) : AbstractDatabase<I
     private Lazy<MainIndexMeta> _mainIndexMeta;
     public MainIndexMeta MainIndexMeta => LazyResolve(ref _mainIndexMeta);
 
-    private Lazy<LocalMetadataDataOperations> _localTags;
-    public LocalMetadataDataOperations LocalMetadataDataOperations => LazyResolve(ref _localTags);
-
     //
     // Connection
     //

src/core/Odin.Core.Storage/Database/Identity/IdentityExtensions.cs

@@ -85,7 +85,6 @@ private static ContainerBuilder RegisterIdentityDatabase(this ContainerBuilder c
 
         // Abstractions
         cb.RegisterType<MainIndexMeta>().InstancePerLifetimeScope();
-        cb.RegisterType<LocalMetadataDataOperations>().InstancePerLifetimeScope();
         return cb;
     }
 

src/core/Odin.Core.Storage/Database/Identity/Table/TableDriveLocalTagIndex.cs

@@ -3,17 +3,72 @@
 using System.Threading.Tasks;
 using Odin.Core.Storage.Database.Identity.Abstractions;
 using Odin.Core.Storage.Database.Identity.Connection;
+using Odin.Core.Time;
 
 namespace Odin.Core.Storage.Database.Identity.Table;
 
 public class TableDriveLocalTagIndex(
     CacheHelper cache,
     ScopedIdentityConnectionFactory scopedConnectionFactory,
     IdentityKey identityKey)
-    : TableDriveLocalTagIndexCRUD(cache, scopedConnectionFactory), ITableMigrator
+    : TableDriveLocalTagIndexCRUD(cache, scopedConnectionFactory: scopedConnectionFactory), ITableMigrator
 {
     private readonly ScopedIdentityConnectionFactory _scopedConnectionFactory = scopedConnectionFactory;
 
+    /// <summary>
+    /// Updates only the local tags table used when Querying the files (querybatch, query-modified, and futures)
+    /// </summary>
+    public async Task UpdateLocalTagsAsync(Guid driveId, Guid fileId, List<Guid> tags)
+    {
+        await using var cn = await _scopedConnectionFactory.CreateScopedConnectionAsync();
+        await using var tx = await cn.BeginStackedTransactionAsync();
+
+        await this.DeleteAllRowsAsync(driveId, fileId);
+        await this.InsertRowsAsync(driveId, fileId, tags);
+
+        tx.Commit();
+    }
+
+    public async Task<int> UpdateLocalAppMetadataAsync(Guid driveId, Guid fileId, Guid newVersionTag, string localMetadataJson)
+    {
+        await using var cn = await _scopedConnectionFactory.CreateScopedConnectionAsync();
+        await using var updateCommand = cn.CreateCommand();
+
+        updateCommand.CommandText = $"UPDATE driveMainIndex " +
+                                    $"SET hdrLocalVersionTag=@hdrLocalVersionTag,hdrLocalAppData=@hdrLocalAppData,modified=@modified " +
+                                    $"WHERE identityId=@identityId AND driveid=@driveId AND fileId=@fileId;";
+
+        var sparam1 = updateCommand.CreateParameter();
+        var sparam2 = updateCommand.CreateParameter();
+        var sparam3 = updateCommand.CreateParameter();
+        var versionTagParam = updateCommand.CreateParameter();
+        var contentParam = updateCommand.CreateParameter();
+        var modifiedParam = updateCommand.CreateParameter();
+
+        sparam1.ParameterName = "@identityId";
+        sparam2.ParameterName = "@driveId";
+        sparam3.ParameterName = "@fileId";
+        versionTagParam.ParameterName = "@hdrLocalVersionTag";
+        contentParam.ParameterName = "@hdrLocalAppData";
+        modifiedParam.ParameterName = "@modified";
+
+        updateCommand.Parameters.Add(sparam1);
+        updateCommand.Parameters.Add(sparam2);
+        updateCommand.Parameters.Add(sparam3);
+        updateCommand.Parameters.Add(versionTagParam);
+        updateCommand.Parameters.Add(contentParam);
+        updateCommand.Parameters.Add(modifiedParam);
+
+        sparam1.Value = identityKey.ToByteArray();
+        sparam2.Value = driveId.ToByteArray();
+        sparam3.Value = fileId.ToByteArray();
+        versionTagParam.Value = newVersionTag.ToByteArray();
+        contentParam.Value = localMetadataJson;
+        modifiedParam.Value = UnixTimeUtcUnique.Now().uniqueTime;
+
+        return await updateCommand.ExecuteNonQueryAsync();
+    }
+
     public new async Task<DriveLocalTagIndexRecord> GetAsync(Guid driveId, Guid fileId, Guid tagId)
     {
         return await base.GetAsync(identityKey, driveId, fileId, tagId);

src/services/Odin.Services/Drives/DriveCore/Query/DriveQuery.cs

@@ -282,19 +282,19 @@ public async Task SaveFileHeaderAsync(StorageDrive drive, ServerFileHeader heade
 
     public async Task SaveLocalMetadataAsync(Guid driveId, Guid fileId, Guid newVersionTag, string metadataJson)
     {
-        await db.LocalMetadataDataOperations.UpdateLocalAppMetadataAsync(driveId, fileId, newVersionTag, metadataJson);
+        await db.DriveLocalTagIndex.UpdateLocalAppMetadataAsync(driveId, fileId, newVersionTag, metadataJson);
     }
 
     public async Task SaveLocalMetadataTagsAsync(Guid driveId, Guid fileId, LocalAppMetadata metadata)
     {
         await using var tx = await db.BeginStackedTransactionAsync();
 
         // Update the tables used to query
-        await db.LocalMetadataDataOperations.UpdateLocalTagsAsync(driveId, fileId, metadata.Tags);
+        await db.DriveLocalTagIndex.UpdateLocalTagsAsync(driveId, fileId, metadata.Tags);
 
         // Update the official metadata field
         var json = OdinSystemSerializer.Serialize(metadata);
-        await db.LocalMetadataDataOperations.UpdateLocalAppMetadataAsync(driveId, fileId, metadata.VersionTag, json);
+        await db.DriveLocalTagIndex.UpdateLocalAppMetadataAsync(driveId, fileId, metadata.VersionTag, json);
 
         tx.Commit();
     }

tests/core/Odin.Core.Storage.Tests/Database/Identity/Table/LocalMetadataOperationsTests.cs

@@ -3,7 +3,6 @@
 using System.Threading.Tasks;
 using Autofac;
 using NUnit.Framework;
-using Odin.Core.Storage.Database.Identity.Abstractions;
 using Odin.Core.Storage.Database.Identity.Table;
 using Odin.Core.Storage.Factory;
 using Odin.Core.Time;
@@ -23,7 +22,7 @@ public async Task UpdateLocalMetadataContentOnly(DatabaseType databaseType)
             await RegisterServicesAsync(databaseType);
             await using var scope = Services.BeginLifetimeScope();
             var tblDriveMainIndex = scope.Resolve<TableDriveMainIndex>();
-            var localTagsDataOperations = scope.Resolve<LocalMetadataDataOperations>();
+            var localTagsDataOperations = scope.Resolve<TableDriveLocalTagIndex>();
 
             var driveId = Guid.NewGuid();
             var fileId = Guid.NewGuid();
@@ -103,7 +102,6 @@ public async Task UpdateLocalMetadataTagsOnly(DatabaseType databaseType)
             await using var scope = Services.BeginLifetimeScope();
             var tblDriveMainIndex = scope.Resolve<TableDriveMainIndex>();
             var tableDriveLocalTagIndex = scope.Resolve<TableDriveLocalTagIndex>();
-            var localTagsDataOperations = scope.Resolve<LocalMetadataDataOperations>();
 
             var driveId = Guid.NewGuid();
             var fileId = Guid.NewGuid();
@@ -151,7 +149,7 @@ public async Task UpdateLocalMetadataTagsOnly(DatabaseType databaseType)
             // Act 
             //
             List<Guid> tags = [Guid.NewGuid(), Guid.NewGuid(), Guid.NewGuid()];
-            await localTagsDataOperations.UpdateLocalTagsAsync(driveId, fileId, tags);
+            await tableDriveLocalTagIndex.UpdateLocalTagsAsync(driveId, fileId, tags);
 
             // 
             // Assert