quick removal of cfm #789
Open
quick removal of cfm #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto introductions
…nto introductions
sebbarg
requested changes
Oct 30, 2024
There was a problem hiding this comment.
See minor comments inline, otherwise looks good (I dont understand the escape hatch for missing file/dir though - see comment).
Perhaps some cleanup in the file DriveFileReaderWriter.cs: everywhere a method returns Task.CompletedTask or Task.FromResult, make it non-async
| logger.LogDebug("WriteStream - using OS locking"); | ||
| bytesWritten = await WriteStreamInternalAsync(filePath, stream); | ||
| } | ||
| logger.LogDebug("WriteStream - using OS locking"); |
| logger.LogDebug("GetAllFileBytes - using OS locking"); | ||
| bytes = await File.ReadAllBytesAsync(filePath); | ||
| } | ||
| logger.LogDebug("GetAllFileBytes - using OS locking"); |
| bytes = await File.ReadAllBytesAsync(filePath); | ||
| } | ||
| logger.LogDebug("GetAllFileBytes - using OS locking"); | ||
| bytes = await File.ReadAllBytesAsync(filePath); | ||
| }); | ||
| } | ||
| catch (TryRetryException e) |
There was a problem hiding this comment.
Why is it not an error if the file or directory is not found?
| @@ -145,25 +108,15 @@ await TryRetry.WithDelayAsync( | |||
| return bytes; | |||
| } | |||
|
|
|||
| public async Task MoveFile(string sourceFilePath, string destinationFilePath) | |||
| public Task MoveFile(string sourceFilePath, string destinationFilePath) | |||
There was a problem hiding this comment.
Return type here should just be void
| } | ||
|
|
||
| /// <summary> | ||
| /// Opens a filestream. You must remember to close it. Always opens in Read mode. | ||
| /// </summary> | ||
| public async Task<Stream> OpenStreamForReading(string filePath) | ||
| public Task<Stream> OpenStreamForReading(string filePath) |
| @@ -233,31 +177,23 @@ private async Task<uint> WriteStreamInternalAsync(string filePath, Stream stream | |||
| return bytesWritten; | |||
| } | |||
|
|
|||
| public async Task DeleteFileAsync(string path) | |||
| public Task DeleteFileAsync(string path) | |||
| } | ||
| catch (TryRetryException e) | ||
| { | ||
| throw e.InnerException!; | ||
| } | ||
|
|
||
| return Task.CompletedTask; | ||
| } | ||
|
|
||
| public async Task DeleteFilesAsync(string[] paths) |
There was a problem hiding this comment.
void instead of Task. Remove Async.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.