New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: losing registered mDNS hosts #137

Merged

jgkawell merged 5 commits into main from fix/lost-mdns

Feb 3, 2025

Member

jgkawell commented Feb 3, 2025 •

edited

Loading

Turned out there were two issues here:

The Start() method was calling AddHost() which would overwrite the config instead of just publishing the hostname to mDNS.
Within draft/pkg/chassis the SaveAndWrite() method was stuck on an infinite mutex lock. That has been fixed here: fix: remove blocking mutex on SetAndWrite() steady-bytes/draft#62

jgkawell added 5 commits

February 2, 2025 19:44


          fix: losing registered mDNS hosts

d134cb5


          undo -> need to use p.cancels in AddHost

f9d24ab


          updated chassis version (to resolve infinite mutex lock)

e8c86b5


          simplify

4ec44f2


          added log back

f3b55ad

jgkawell merged commit b49e286 into main

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet