Cleanup LG webOS TV name #135028
Merged
Cleanup LG webOS TV name #135028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
bugfix
cla-signed
code-quality
has-tests
integration: webostv
small-pr
thecode
commented
Jan 7, 2025
| @@ -11,7 +11,7 @@ | |||
| PLATFORMS = [Platform.MEDIA_PLAYER] | |||
| DATA_CONFIG_ENTRY = "config_entry" | |||
| DATA_HASS_CONFIG = "hass_config" | |||
| DEFAULT_NAME = "LG webOS Smart TV" | |||
| DEFAULT_NAME = "LG webOS TV" | |||
There was a problem hiding this comment.
This was changed since I noticed the device name in SSDP discovery does not include the word Smart, this is also what shown on the manufacturer app. I consider removing the term smart from the docs also
thecode
commented
Jan 7, 2025
| @@ -36,7 +36,7 @@ async def test_diagnostics( | |||
| "in1": {"appId": "app0", "id": "in1", "label": "Input01"}, | |||
| "in2": {"appId": "app1", "id": "in2", "label": "Input02"}, | |||
| }, | |||
| "system_info": {"modelName": "TVFAKE"}, | |||
| "system_info": {"modelName": "MODEL"}, | |||
There was a problem hiding this comment.
To limit PR size, diagnostics will be changed to use snapshots in follow up PR
thecode
commented
Jan 7, 2025
| config-flow-test-coverage: todo | ||
| config-flow-test-coverage: | ||
| status: todo | ||
| comment: remove duplicated config flow start in tests, make sure tests ends with CREATE_ENTRY or ABORT, use hass.config_entries.async_setup instead of async_setup_component, snapshot in diagnostics (and other tests when possible), test_client_disconnected validate no error in log |
There was a problem hiding this comment.
Moved the test related todo to the correct place
joostlek
approved these changes
Jan 8, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Follow-up for #133732
[]from SSDP discovery name to make the device name cleaner.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: