Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cookidoo-api to 0.12.1 #134999

Closed

Conversation

miaucl
Copy link
Contributor

@miaucl miaucl commented Jan 7, 2025

Ingredients can be fixed quantity or ranged quantity, we now support both.

https://github.com/miaucl/cookidoo-api/blob/master/CHANGELOG.md
https://github.com/miaucl/cookidoo-api/releases/tag/0.12.1

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@epenet epenet changed the title Bump cookidoo-api to support range in ingredient quantity for Cookidoo integration Bump cookidoo-api to 0.12.1 Jan 7, 2025
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:

  • A link to the release notes of this package version, and all versions in between.
  • A link to the changelog of this package.
  • A link to a Git(Hub) diff/compare view from the current version to the bumped version.

This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

Thanks already! 👍

@home-assistant home-assistant bot marked this pull request as draft January 7, 2025 18:09
@home-assistant
Copy link

home-assistant bot commented Jan 7, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@miaucl
Copy link
Contributor Author

miaucl commented Jan 7, 2025

Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:

  • A link to the release notes of this package version, and all versions in between.

  • A link to the changelog of this package.

  • A link to a Git(Hub) diff/compare view from the current version to the bumped version.

This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

Thanks already! 👍

Sorry, for sure, dunno why i forgot it.

@miaucl miaucl marked this pull request as ready for review January 7, 2025 18:37
@home-assistant home-assistant bot requested a review from joostlek January 7, 2025 18:37
Copy link
Member

@zweckj zweckj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a link to the actual release version, so it doesn't get lost in time

@home-assistant home-assistant bot marked this pull request as draft January 7, 2025 21:03
@miaucl
Copy link
Contributor Author

miaucl commented Jan 7, 2025

Please add a link to the actual release version, so it doesn't get lost in time

Done

@miaucl miaucl marked this pull request as ready for review January 7, 2025 21:17
@home-assistant home-assistant bot requested a review from zweckj January 7, 2025 21:17
@miaucl
Copy link
Contributor Author

miaucl commented Jan 7, 2025

Superseeded by #135045

@miaucl miaucl closed this Jan 7, 2025
@miaucl miaucl deleted the cookidoo_ingredient_quantity_range branch January 7, 2025 22:10
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cookidoo integration. Configuration failed, will try again: update_exception
3 participants