-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump stookwijzer to v1.5.1 #131567
Merged
Merged
Bump stookwijzer to v1.5.1 #131567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
breaking-change
cla-signed
dependency
integration: stookwijzer
small-pr
PRs with less than 30 lines.
labels
Nov 25, 2024
Hey there @fwestenberg, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
20 tasks
joostlek
reviewed
Nov 25, 2024
joostlek
approved these changes
Nov 25, 2024
CI error isn't related to this PR. I'll go ahead on the merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
breaking-change
cla-signed
dependency
integration: stookwijzer
Quality Scale: No score
small-pr
PRs with less than 30 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
The Stookwijzer sensor has migrated to the new API provided by Atlas Leefomgeving. As a result, the reported states are slightly different.
Old vs new:
blauw
) -> Yellow (code_yellow
)oranje
) -> Orange (code_orange
)rood
) -> Red (code_red
)If you use the Stookwijzer sensor in your automations or scripts, you might need to adjust those for this change.
Proposed change
Extracted from #104846
Upgrades
stookwijzer
to v1.5.1Diff: fwestenberg/stookwijzer@v1.3.0...v1.5.1
This PR does the bump and upgrades the bare minimum to the integration + tests.
Although a little out of scope, I did add the tests for diagnostics & sensors platforms, mostly because they were almost no effort to create and showcase the output in this PR.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: