Skip to content

Commit

Permalink
Fix ESPHome and VoIP Assist satellite entity names (#126229)
Browse files Browse the repository at this point in the history
Co-authored-by: Paulus Schoutsen <[email protected]>
  • Loading branch information
synesthesiam and balloob authored Sep 26, 2024
1 parent 185d00c commit 9db5b48
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 11 deletions.
5 changes: 5 additions & 0 deletions homeassistant/components/esphome/strings.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,11 @@
}
},
"entity": {
"assist_satellite": {
"assist_satellite": {
"name": "[%key:component::assist_satellite::entity_component::_::name%]"
}
},
"binary_sensor": {
"assist_in_progress": {
"name": "[%key:component::assist_pipeline::entity::binary_sensor::assist_in_progress::name%]"
Expand Down
3 changes: 2 additions & 1 deletion homeassistant/components/voip/assist_satellite.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
AssistSatelliteEntityDescription,
)
from homeassistant.config_entries import ConfigEntry
from homeassistant.const import EntityCategory
from homeassistant.core import Context, HomeAssistant, callback
from homeassistant.helpers.entity_platform import AddEntitiesCallback

Expand Down Expand Up @@ -79,7 +80,7 @@ class VoipAssistSatellite(VoIPEntity, AssistSatelliteEntity, RtpDatagramProtocol

entity_description = AssistSatelliteEntityDescription(key="assist_satellite")
_attr_translation_key = "assist_satellite"
_attr_has_entity_name = True
_attr_entity_category = EntityCategory.CONFIG
_attr_name = None

def __init__(
Expand Down
10 changes: 0 additions & 10 deletions homeassistant/components/voip/strings.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,6 @@
}
},
"entity": {
"assist_satellite": {
"assist_satellite": {
"state": {
"listening_wake_word": "[%key:component::assist_satellite::entity_component::_::state::listening_wake_word%]",
"listening_command": "[%key:component::assist_satellite::entity_component::_::state::listening_command%]",
"responding": "[%key:component::assist_satellite::entity_component::_::state::responding%]",
"processing": "[%key:component::assist_satellite::entity_component::_::state::processing%]"
}
}
},
"binary_sensor": {
"call_in_progress": {
"name": "Call in progress"
Expand Down
1 change: 1 addition & 0 deletions tests/components/esphome/test_assist_satellite.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ def get_satellite_entity(
)
if satellite_entity_id is None:
return None
assert satellite_entity_id.endswith("_assist_satellite")

component: EntityComponent[AssistSatelliteEntity] = hass.data[
assist_satellite.DOMAIN
Expand Down
1 change: 1 addition & 0 deletions tests/components/voip/test_voip.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ def async_get_satellite_entity(
)
if satellite_entity_id is None:
return None
assert not satellite_entity_id.endswith("none")

component: EntityComponent[AssistSatelliteEntity] = hass.data[
assist_satellite.DOMAIN
Expand Down

0 comments on commit 9db5b48

Please sign in to comment.